Update: UltraVNC 1.4.3.6 and UltraVNC SC 1.4.3.6: https://forum.uvnc.com/viewtopic.php?t=37885
Important: Please update to latest version before to create a reply, a topic or an issue: https://forum.uvnc.com/viewtopic.php?t=37864

Join us on social networks and share our announcements:
- Website: https://uvnc.com/
- GitHub: https://github.com/ultravnc
- Mastodon: https://mastodon.social/@ultravnc
- Facebook: https://www.facebook.com/ultravnc1
- X/Twitter: https://x.com/ultravnc1
- Reddit community: https://www.reddit.com/r/ultravnc
- OpenHub: https://openhub.net/p/ultravnc

Code quality

Developers may discuss here
Post Reply
RomekAtomek
Posts: 3
Joined: 2020-07-02 23:48

Code quality

Post by RomekAtomek »

Is there a reason to call GetDIBits twice in the vncdesktop.cpp file?

line 1118

result = ::GetDIBits(m_hmemdc, m_membitmap, 0, 1, NULL, &m_bminfo.bmi, DIB_RGB_COLORS);
if (result == 0) {
vnclog.Print(LL_INTERR, VNCLOG("unable to get display format\n"));
return ERROR_DESKTOP_NO_DISPLAYFORMAT;
}
result = ::GetDIBits(m_hmemdc, m_membitmap, 0, 1, NULL, &m_bminfo.bmi, DIB_RGB_COLORS);
if (result == 0) {
vnclog.Print(LL_INTERR, VNCLOG("unable to get display colour info\n"));
return ERROR_DESKTOP_NO_DISPLAYFORMAT;
}
User avatar
Rudi De Vos
Admin & Developer
Admin & Developer
Posts: 6863
Joined: 2004-04-23 10:21
Contact:

Re: Code quality

Post by Rudi De Vos »

is needed
Post Reply