V1.23.1 problems

[thegaffer14]

V1.23.1 seems to have several problems. MRU and the SessionDialog combo box doesn't function correctly.

1) MRU::AddItem needs move the trailing 0 as well
for (int j = _tcslen(m_index)+1; j >= 0; j--) instead of for (int j = _tcslen(m_index); j >= 0; j--)
then
m_index[MRU_MAX_ITEM_LENGTH] = _T('\0');
after the loop

2) The SessionDialog combo box message handler needs to change in order to execute a user selection and display it
case IDC_HOSTNAME_EDIT:
if (HIWORD(wParam) == CBN_SELCHANGE) {
TCHAR hostname[256];
int ItemIndex = SendMessage((HWND) lParam, CB_GETCURSEL, 0, 0);
SendMessage((HWND) lParam, (UINT) CB_GETLBTEXT, (WPARAM) ItemIndex, (LPARAM) hostname);
_this->m_pMRU->RemoveItem(hostname);
_this->m_pMRU->AddItem(hostname);
_this->IfHostExistLoadSettings(hostname);
_this->SettingsToUI();
}
if (HIWORD(wParam) == CBN_SELENDOK) {
TCHAR hostname[256];
int ItemIndex = SendMessage((HWND)lParam, CB_GETCURSEL, 0, 0);
SendMessage((HWND)lParam, (UINT)CB_SETCURSEL, (WPARAM)ItemIndex, (LPARAM)hostname);
}
break;


3) Saved settings with file names like this sprintf_s(fname, "%.10s-%d.vnc", tmphost, (disp > 0 && disp < 100) ? disp : port);
will cause problems as different servers on the same network will be saved to the same file.

4) Running viewer debugging (either x86 or x64) with encryption causes exceptions due to heap corruption.

P.S also
SessionDialog::InitDlgProcSecurity() needs

// Update the use encryption check box
HWND hfUseEncryption = GetDlgItem(hwnd, IDC_PLUGIN_CHECK);
SendMessage(hfUseEncryption, BM_SETCHECK, fUseDSMPlugin, 0);

[Rudi De Vos]

missed this post gonna check it

[Rudi De Vos]

heap corruption
https://github.com/veyon/ultravnc/blob/ ... .cpp#L3602
Was set to small using the plugin we add the plugin name to the titlebar

[thegaffer14]

Thanks that seems to have fixed it