Possible bug in repeater "only allow ID" function

[mraluminumsiding]

There seems to be a limit of ~12 IDs you can have defined on the repeater, otherwise it will crash on strartup. Should I put them on separate lines so it can parse them more easily, or is there actually a limit? I didn't see one expressed in any docs.

[YY]

I had tried on the PHW repeater & UVNC repeater with 15-20 IDs entered, both worked w/o problem. I input all IDs in a single line and each is separated with a comma.

Can you advise more details of your test environment: OS; which repeater & version; what IDs you had entered, etc.

[mraluminumsiding]

The repeater is the version that came with PHW 1.0, running on Windows XP Pro SP2. The magic number of IDs seems to be 20.

The IDs themselves were randomly generated 4-digit numbers, then randomly generated 3-digit numbers, then consecutive numbers from 1-20. The IDs themselves didn't seem to matter - any more than 20 and the repeater crashed on startup.

I was separating the IDs with a semicolon, as was indicated by the example above that form field. I didn't try commas, but it seems like if I used the wrong character it would fail well before 20 IDs.

[YY]

I was separating the IDs with a semicolon, as was indicated by the example above that form field. I didn't try commas, but it seems like if I used the wrong character it would fail well before 20 IDs.

OK! I can repeat the crash -- with the use of semicolon as separator.

However, the example above that form field using the COMMA as separator, not the semicolon!!

I can input as many as 25 IDs separated with comma w/o problem.

[mraluminumsiding]

Confirmed, using a comma I can input up to 50 IDs.

Thanks, that would never have occurred to me.

However, the example above the field, on my version (PCHW Repeater Rel1.0) shows a semicolon:



Kinda hard to read, though. How weird that using the wrong delimiter would work at all!

Is there a newer version of the repeater for PCHW?

[YY]

Oh!!!! You are right!!!
The example above the field in PHW repeater is actually a semicolon, because it is so small in my screen (1280 x 1024), I used to identifed it as a comma.

However, a comma works better !?!?

>>>>>Is there a newer version of the repeater for PCHW?
I don't see any offical release, but redge (the moderator) had advised some other releases that even able to support both UVNC and PcHelpWare, reference [topic=12021]Compatibility of PcHelpWare Repeater with UltraVNC/SC
[/topic]

[YY]

Hi! mraluminumsiding

I want to say sorry about my statement about using the comma in the ID Restriction Setting.
It is TOTALLY WRONG .... although the repeater accepts the input of plenty of IDs, yet the repeater not accessing them correctly.

You are right, we must use the semicolon as delimiter.

I have run a lot of test on the PHW repeater, it showed the repeater not interpret the IDs if they are separated with comma, semicolen is the right delimiter. I also tried to find out how many IDs can be handled by the repeater. Here is the result:
1. When input with 25 (or less) IDs, the repeater will be running properly.
2. When input with 26-29 IDs, the repeater can still be running, and operate its function as expected. However, the Setting, Exit etc will not be available at the tray icon.
3. When input with 30 or more IDs, the repeater will crash at start.
4. The total length of the text looks like has a limitation too. It is about 150 characters max., but I have not find out exact value yet.

Hope these info can help anyone who may need to use this function of the repeater.

[mraluminumsiding]

Yeah, that is pretty much the same set of results I'm getting, regarding number of IDs and repeater behavior.

I haven't, though, noticed any particular limit on overall string length. if I enter the numbers 1-30 I still get a crash, but 1-20 is fine. Same with random 7-digit numbers (which shouldn't even work at all): 20 works okay, 30 crashes the repeater on startup.

Overall string length as a limitation makes more sense though. Otherwise it seems like.. what, an array with a set size maybe?

[mraluminumsiding]

Update

It would appear that repeater v. 1.2.2.2 works with PCHelpWare.

Every version of repeater 1.0 - 1.2.2.2 for uVNC will take unlimited IDs and start up just fine, but will crash on connect if there are more than 24.

PCHW_Repeater I have a couple of versions - both of them say "for PCHelpWare Rel 1.0" but they've got different dates. Both of these crash on startup if there are more than 24 IDs configured.

ID length doesn't matter, neither does overall length of that string.

This appears to be a built-in limitation. I'm playing with the source for 1.2.2.2 to see if I can fix this.

[Rudi De Vos]

Indeed there is a limitation of 24, hardcoded.
But is it was just a parameter is now set to
210
input string is limited to 1024 chars
"1234;1235" == 9 chars

http://sc.uvnc.com/105/specialbuild

source changes

Code: Select all

char temp3[500][16];<<<<<<<<<<<


rule1=0; <<<<<<<<<<<
while (test)
{
..
rule1++;
..
}
rule2=0;<<<<<<<<<<<

while (test)
{
..
rule2++;
..
}
rule3=0;<<<<<<<<<<<

while (test)
{
..
rule3++
..
}

[mraluminumsiding]

OMG you're awesome.

Ah, okay. I see what you changed. temp3[50][16] to temp3[500][16]... it was an array.

saved_sample3[1024] is the 1024-byte string limit, right?

1024 bytes is 204 4-digit IDs, so that should probably be enough for me.

Thanks again!