MSRC4Plugin 1.2.0 and 1.2.1 are NG

[scovel]

MSRC4Plugin 1.2.0 and 1.2.1 are no good, at least on Windows 2000. The fix is not going to be quick. Either revert to 1.1.8, or switch to one of the OpenSSL based plugins. The ARC4 plugin is also RC4 based encryption. The AESV2 version is even MORE SECURE.

Hopefully I'll find the bug in the next week.

Sean

[averkiev]

Sean,
while reviewing the source code for MSRC4 v1.2.1 plug-in, I found quite a few places in the code that doesn't look good and error prone.

Like when you declare a buffer of char[256] for key file name. Have you tried to check what gonna happen when the file path is longer than that?

You are welcome to ping me via MSN at averkiev_y@hotmail.com so I could help you to improve the code.

Regards,
Yury

[scovel]

Yury,

That's not a very friendly way to start a conversation!

Have YOU looked at what will happen? At worst the filename will get truncated.

If you have other concerns or patches you'd like to submit, feel free to Email me directly.

Sean

[averkiev]

Hi Sean,
sorry I don't meant to be rude.

I've sent you a PM with some other problems outlined.

Yury

[Astro]

Hello,

I am new with ultravnc and MSR4Plugin.

Until yesterday I used UltraVNC V1.0.1 and MSRC4Plugin v1.1.8

UVNCViewer on Win 2K Pro <--> UVNCServer on Win XP Pro ---> [OK]
UVNCViewer on Win XP Pro <--> UVNCServer on Win XP Pro ---> [OK]

Now I use UltraVNC V1.0.2 and MSRC4Plugin v1.2.1:

UVNCViewer on Win 2K Pro <--> UVNCServer on Win XP Pro ---> [NOK]
UVNCViewer on Win XP Pro <--> UVNCServer on Win XP Pro ---> [OK]

So I can confirm that under windows 2000, the latest MSRC4Plugin doesn't
work correctly!

Regards,
Asto

Under the MSRC4Plugin download website, the "whatsnew.txt" file into
the zip Archive from the last version (1.2.1) is not up2date! It contains the news info from the v1.1.8...

[scovel]

There is a new BETA, 1.2.2. RC1, that I hope fixes the problem on Windows 2000. If you try it out, let me know how your testing goes, and what OS you tested on.

Sean


[topic=7420][/topic]

[redge]

There a final build, please upgrade to MSRC4Plugin 1.2.2.0
[topic=7441][/topic]

[redge]

salting is disabled in the MSRC4 plugin due to Windows 2000 incompatibility

Is it really Salting issue or only the bug of %temp% not in use by all plugin msrc4plugin ?

fixed %temp% issue with custom build of msrc4 1.4.0 by pgmoney
won't see the official msrc4plugin.dsm with temp folder fixed.

I can't check my self, actually i won't have w2k