Repeater hangs

[_Ghost__]

Hi Rudy, I would like to see the source of your patch of the repeater.
I did a lot of cleanup on the repeater source, removing old legacy and unused code (from the old console version I think) and fixing a couple of bugs.
For now it is at http://www.gullibet.com/tmp/vnc/repeater_src.rar , anyone is encouraged to see and test it.
You can put it on sourceforge or send it at davidecapod AT inwind.it.

Thanks
Davide

[mod=494,1137102822]moved the comma obstructing the hypertext link [/mod]

[redge]

_Ghost_ ,
So great works, very good, tested sound good
I think the staff of UltraVNC would you as welcome to enter to devs staff of UltraVNC if you want.

3 thinks for end user (for ergonomic usage, friendly human)
is not a bad critic at all, just way for fix from end user view.

your repeater (12.01.2005) running as service SYSTEM mode on XP Pro SP2 US

• right click on repeater systray, left click select Log
  again right click on repeater systray, and you see Settings is checked instead of Log.
  clean log and retry to start log,
  --- start edit1 ----
  no log until new connection
  no table of connections available realtime (feature?)
  --- end edit1 ---
• counting server from 0 to 19 (programmer) would be human from 1 to 20
• list of active connections server and viewers not sync to reflect table connections made as direct mode I and mode II (ID)
  -- start edit2---
  server empty for mode I but would be great to know wish server mode I connected to viewer mode I on the table
  -- end edit2---

[syntax="text"]
socket() initialized
bind() succeded to port 5901
listen() succeded
THREAD VIEWER: 868
socket() initialized
bind() succeded to port 5500
listen() succeded
THREAD SERVER: 3164
THREAD TIMER: 3012
Server accept
DBG: remotehost 12345678 remoteport 5900
DBG: 'ID' not valid
Server accept
DBG: remotehost ID remoteport 12345678
13/01/2006 01:50:28 Server added to list 12345678
Viewer accept
DBG: remotehost ID remoteport 12345678
13/01/2006 01:51:13 Viewer added to list 12345678
--> Repeater ID 12345678 started
Connections at 13/01/2006 01:51:4
Server 0: 12345678 1 192.168.1.100: 1067 Viewer 0: 12345678 1 192.168.1.32: 1992
Server 1: 0 0 : 0 Viewer 1: 0 0 : 0
Server 2: 0 0 : 0 Viewer 2: 0 0 : 0
...
Server 19: 0 0 : 0 Viewer 19: 0 0 : 0
Viewer accept
DBG: remotehost 192.168.1.10 remoteport 5900
connecting to 192.168.1.10:5900
connected
start relaying.
[/syntax]
[syntax="text"]
DBG: remotehost 192.168.1.10 remoteport 5900
connecting to 192.168.1.10:5900
connected
start relaying.
Connections at 13/01/2006 02:36:4
Server 0: 0 0 : 0 Viewer 0: 5900 0 192.168.1.32: 2047
[/syntax]
Anyway, Thanky you very much for your free time of debugging and log improvements.

[_Ghost_]

> # right click on repeater systray, left click select Log
> again right click on repeater systray, and you see Settings is checked instead of Log.
>clean log and retry to start log,

I think that also the GUI needs some cleaning... I'm not a GUI programming lover but I'll do it when I will have some spare time

> # counting server from 0 to 19 (programmer) would be human from 1 to 20

no problem, more time to write this than do it

> # list of active connections server and viewers not sync to reflect table connections made as direct mode I and mode II (ID)

that's because connections in mode I (proxy) are NOT tracked through a list of peers as in mode II (repeater), they are immediately started as the the viewer connects; although I think it's not an hard work to keep a list of them.

Bye
Davide

[Rudi De Vos]

Added sourcecode V107

http://sc.uvnc.com/sc
Distributer107_src.zip

Didn't have time to compare _Ghost__ changes with my own.
Perhaps someone can merge them, code isn't that big

[_Ghost_]

http://sc.uvnc.com/sc gives me a page with "Restricted" while
http://sc.uvnc.com/sc/Distributer107_src.zip a "Not found" error

[RepeaterNotResponding]

Hi Davide,
Go to http://sc.uvnc.com/V2/ . They posted the wrong url. By the way the repeater that you sent me has been working perfectly. I haven't had to restart the service since you sent it to me. Thanks again.
Joe

[_Ghost_]

Avaible my new version of the repeater at
http://www.gullibet.com/tmp/vnc/repeater_src_1801.rar

I included Rudi patch to spawn a new thread after the accept() with some modifications:
- no need to spawn another thread for do_repeater, we already are in the new thread context
- no need for Events to pass parameters byref, just passing the socket by value
- added critical sections handling when adding/removing clients from the lists
- added mode I list logging
- more detailed logging
- .rc updates
- some bugfixes

Please test this A LOT since these are big modifications in the code since the previous version.

Bye
Davide

[redge]

_Ghost_

first look,
repeater 1.2.2.0 as SYSTEM (18.01.12005)
3 request are done successful ( flag log, list repeater 1-20, list of proxy)


some tests made:
1x GSM EDGE 256 kbit/s --> Internet --> NAT/router/proxy --> internal LAN 100 Mbits/s (mode I)
1x WLAN 54Mbit/s --> repeater <-- LAN 100 Mbit/s (mode II)
1x LAN 100 --> proxy --> LAN 100 Mbit/s (mode I)


Thank you a lot again for your time and the great work :-)
I think would be great idea to join dev staff of UltraVNC V2 ;-) ?

[_Ghost_]

Started a new thread...
[topic=5601][/topic]

The repeater does not hang anymore (hopefully)