Code quality

Developers may discuss here.

Code quality

Postby RomekAtomek » 2020-07-06 17:01

Is there a reason to call GetDIBits twice in the vncdesktop.cpp file?

line 1118

result = ::GetDIBits(m_hmemdc, m_membitmap, 0, 1, NULL, &m_bminfo.bmi, DIB_RGB_COLORS);
if (result == 0) {
vnclog.Print(LL_INTERR, VNCLOG("unable to get display format\n"));
return ERROR_DESKTOP_NO_DISPLAYFORMAT;
}
result = ::GetDIBits(m_hmemdc, m_membitmap, 0, 1, NULL, &m_bminfo.bmi, DIB_RGB_COLORS);
if (result == 0) {
vnclog.Print(LL_INTERR, VNCLOG("unable to get display colour info\n"));
return ERROR_DESKTOP_NO_DISPLAYFORMAT;
}
RomekAtomek
 
Posts: 3
Joined: 2020-07-02 23:48

Return to Developer discussions (mainly user-mode)

Who is online

Users browsing this forum: No registered users and 1 guest